spec
spec copied to clipboard
cloudevents
Vanity go package name in spec.proto should work
Spec.proto uses a go package name of cloudevents.io/genproto/v1, but this URL does not contain the go vanity meta tags, which causes go to produce errors like:
cannot find module providing package cloudevents.io/genproto/v1: unrecognized import path "cloudevents.io/genproto": reading https://cloudevents.io/genproto?go-get=1: 404 Not Found
cloudevents.io/genproto should return a page that contains:
<meta name="go-import" content="cloudevents.io/genproto git https://github.com/cloudevents/genproto">
<meta name="go-source" content="cloudevents.io/genproto https://github.com/cloudevents/genproto https://github.com/cloudevents/genproto/tree/master{/dir} https://github.com/cloudevents/genproto/blob/master{/dir}/{file}#L{line}">
And a genproto repo should exist with the generated .pb.go files and a go.mod that has module cloudevents.io/genproto/v1
or @n3wscott @evankanderson since you guys might have some insight on how best to fix this too.
We'll need to publish a static page like these on the Netlify site (assuming Netlify is what's being used).
Html fragments: https://github.com/knative/website/tree/master/static/golang
Netlify _redirects file:
https://github.com/knative/website/blob/master/static/_redirects
I would admit to having inserted the go directives based on commentary I got at the time.
I also don't claim to be a "go expert" and had naively assumed that this would only really be needed for local code generation and not require an actual repo.
As such I defer to those with much more hands-on than me :-)
Oh! I lost this thread, sure I will ping you @duglin and see what backs cloudevents.io, it would be cool to host the go sdk there too!!
See: https://github.com/cloudevents/cloudevents-web for the hosting side of things. Scott to look into it