spec icon indicating copy to clipboard operation
spec copied to clipboard

[Subscription API] I get confused by introduction section about filter dialects

Open HenriKorver opened this issue 2 years ago • 10 comments

Section 3.2.4.1 Filter Dialects tells that Filter dialects are identified by a unique URI-Reference.

{ "dialect URI-Reference" : { <dialect-specific-properties> } }

However, in the first filter dialect that MUST be supported following the specification the attribute exact does not look as a unique URI-reference to me.

{ "exact": { "type": "com.github.push", "subject": "https://github.com/cloudevents/spec" } }

HenriKorver avatar Jul 30 '22 11:07 HenriKorver

While short, I think it is a valid URI-ref per https://www.rfc-editor.org/rfc/rfc3986#section-4.1

We kind of cheated a little by grabbing such a short one and perhaps we should make it more official with something like http://cloudevents.org/filters/.... but that's a lot of typing for common ones. :-)

Do you see an issue with us using it?

duglin avatar Aug 09 '22 20:08 duglin

I want to work to fix this issue

Prakharkarsh1 avatar Sep 10 '22 08:09 Prakharkarsh1

This issue is stale because it has been open for 30 days with no activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Feb 25 '23 01:02 github-actions[bot]

/remove-lifecycle stale

HenriKorver avatar Feb 25 '23 11:02 HenriKorver

This issue is stale because it has been open for 30 days with no activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Apr 19 '23 01:04 github-actions[bot]

/remove-lifecycle stale

HenriKorver avatar Apr 19 '23 06:04 HenriKorver

This issue is stale because it has been open for 30 days with no activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 20 '23 01:05 github-actions[bot]

/remove-lifecycle stale

HenriKorver avatar May 22 '23 08:05 HenriKorver

This issue is stale because it has been open for 30 days with no activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jul 08 '23 01:07 github-actions[bot]

@Prakharkarsh1 were you going to work on this one?

Although, I'm not sure what the fix is since it's technically legal

duglin avatar Mar 20 '24 19:03 duglin