sdk-python icon indicating copy to clipboard operation
sdk-python copied to clipboard
verified publisher icon cloudevents

Modified content-type to abide by attribute naming conventions for cloudevents

Open vivjd opened this issue 1 year ago • 5 comments

Fixes #211

Changes

The content-type attribute will violate the attribute naming rules, so the attribute has been modified to datacontenttype.

One line description for the changelog

Converted content-type to datacontenttype for cloudevents.

  • [x] Tests pass

vivjd avatar Jan 06 '24 17:01 vivjd

Hey @vivjd, thx for opening the PR.

Unfortunately your change is not really what the desired behavior should be. I've mentioned the desired one here: https://github.com/cloudevents/sdk-python/issues/211#issuecomment-1533212334

So if you're up for changing this to comply with the desired behavior I'd be glad to review the PR.

xSAVIKx avatar Jan 06 '24 19:01 xSAVIKx

Hi @xSAVIKx! Thank you for you feedback. I've reread the original issue and the desired behavior, and changed it accordingly in my PR. If you could review the PR that would be great! Thank you for your time!

vivjd avatar Jan 20 '24 16:01 vivjd

Hi @xSAVIKx, I changed the test cases to match the change. Could you please kindly review this again? Thank you in advance!

vivjd avatar Mar 31 '24 16:03 vivjd

Hey @xSAVIKx @duglin would one of you be able to approve the workflows on this PR?

Cali0707 avatar Apr 06 '24 15:04 Cali0707

Sorry, my bad. I was pretty sure I did that when I was reviewing the PR

xSAVIKx avatar Apr 06 '24 19:04 xSAVIKx