sdk-go

sdk-go copied to clipboard

Consider making it easier to detect if an event is returned, or if there's no event, or if it's malformed.

1

As part of: https://github.com/knative/eventing/pull/3450 (and the discussions around how to handle empty events...) Wanted to float by changing the behaviour of: https://github.com/cloudevents/sdk-go/blob/master/v2/binding/to_event.go#L23 For handling empty responses differently from a malformed...

vaikas

Perhaps Send should break apart protocol error from result.

2

> Perhaps the API would have been simpler if we returned (Receipt, error) and broken out the 3. case into a distinct thing, and then Receipt could be nil in...

n3wscott

"if present" validation

5

We are getting this issue reported against Event Grid: https://twitter.com/jonatasbaldin/status/1256512556782452737?s=20 "currently, the `cloudschema` field is present but empty, and, per the spec: "If present, MUST be a non-empty URI"" My...

clemensv

[Webhook] Implement Allowed Origin

2

n3wscott

[Webhook] Implement Callback in webhook

2

n3wscott

Support pubsub push

6

I'd like to run an event handling service on a serverless platform, like Cloud Run or Cloud Functions. This requires the service respond to http requests ([example](https://cloud.google.com/run/docs/triggering/pubsub-push)). The current cloudevents...

majelbstoat

Ref: https://github.com/cloudevents/spec/blob/master/extensions/sampled-rate.md

n3wscott

Ref: https://github.com/cloudevents/spec/blob/master/extensions/dataref.md

n3wscott

Maybe in a followup, but we need a test for the use case: > I want to set a receiver that doesn't accept events, accepts method `GET`, and the user...

n3wscott

Maybe we could use this https://github.com/rs/cors/blob/master/cors.go or something similar to validate the origins, let's do it in a follow up. _Originally posted by @slinkydeveloper in https://github.com/cloudevents/sdk-go/pull/491_

n3wscott