sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

Provide examples how you think people should use Protobuf

Open AndreasBergmeier6176 opened this issue 2 years ago • 1 comments

At least to me the design decisions that this library took are not obvious. Also I have no idea how the library authors think people should use this library. Obvious to me would be:

ev := pb.CloudEvent{}
err := protobufv2.DecodeData(ctx, m.Value, &ev)

but as mentioned in other issues that does not work since pb package is under internal and not at the correct stage.

AndreasBergmeier6176 avatar Aug 12 '22 12:08 AndreasBergmeier6176

I agree.

I think we should make a full fledged proto transport. What do you think?

n3wscott avatar Aug 12 '22 17:08 n3wscott

@AndreasBergmeier6176 can this be closed now that pb got moved outside internal?

embano1 avatar Dec 09 '22 07:12 embano1

Indeed. Additional Bonus points would be showing up in buf.build.

AndreasBergmeier6176 avatar Dec 12 '22 06:12 AndreasBergmeier6176