sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

Published 20 hours ago • verified publisher icon cloudevents

Extension name with more than 20 characters throws error

Open deissnerk opened this issue 3 years ago • 5 comments

SetExtension() of the v1.0 event context throws an error, if the name of the extension is longer than 20 characters. In the spec this length restriction is a SHOULD NOT restriction. So failing with an error seems to be too strong. Shouldn't it be possible to violate SHOULD requirements? 😉

deissnerk avatar Apr 08 '21 17:04 deissnerk

It should be possible. Good point. What version of the sdk are you seeing this in? it is in the latest 2.4.0?

n3wscott avatar Apr 08 '21 21:04 n3wscott

We experienced it first with the 2.4.0 release. I think it might have sneaked in with this commit.

deissnerk avatar Apr 09 '21 09:04 deissnerk

Yep. ok thanks! I will get a point fix release out in the next couple days.

n3wscott avatar Apr 09 '21 20:04 n3wscott

Thank you. If it is only about removing the length check, I can come up with a little PR, too.

deissnerk avatar Apr 12 '21 11:04 deissnerk

@deissnerk If you want to write the PR, that would be great, I was thinking of having a global setting that an importer can set the max length to something they wish, but have the default be unlimited (0).

n3wscott avatar Apr 12 '21 15:04 n3wscott