sdk-go
sdk-go copied to clipboard
fix: LIKE expression with invalid string literals returns a parse error instead of panicking
Fixes #931
When visiting the nodes of the AST while parsing the LIKE expression, it looks like we assumed that we would have a valid string literal. However, it is possible that there is no valid string literal, in which case we have to handle that and return an error rather than continuing to parse (and subsequently panicking)
cc @duglin @pierDipi @lionelvillard
Aside from my minor question, LGTM
cc @embano1
do we have a testcase for this?
do we have a testcase for this?
@duglin yes, the new tck test in this PR runs and passes with this change, but prior to the change it would panic
@duglin for final approval/merge
LGTM - it needed a rebase so kicked that off...
merging...