sdk-csharp icon indicating copy to clipboard operation
sdk-csharp copied to clipboard

Make library AOT compatible

Open giggio opened this issue 2 years ago • 5 comments

Right now we are getting warnings, like:

/home/user/.nuget/packages/cloudnative.cloudevents.systemtextjson/2.7.1/lib/netstandard2.1/CloudNative.CloudEvents.SystemTextJson.dll : warning IL2104: Assembly 'CloudNative.CloudEvents.SystemTextJson' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/app/consumer.csproj]
/home/user/.nuget/packages/cloudnative.cloudevents.systemtextjson/2.7.1/lib/netstandard2.1/CloudNative.CloudEvents.SystemTextJson.dll : warning IL3053: Assembly 'CloudNative.CloudEvents.SystemTextJson' produced AOT analysis warnings. [/app/consumer.csproj]

giggio avatar Oct 18 '23 01:10 giggio

I'm afraid I don't have enough experience with AOT (or time to get up to speed) to work on this. I'd happily review a PR to address it, however.

jskeet avatar Oct 18 '23 06:10 jskeet

@jskeet I just added a PR for it, it was a lot of work, I need revision to make sure everything is ok.

giggio avatar Nov 11 '23 02:11 giggio

hi @jskeet , does this library is AOT compatible now?

I would like to use it for a test as an extention for https://github.com/AxaFrance/SlimFaas

guillaume-chervet avatar Aug 21 '24 14:08 guillaume-chervet

@guillaume-chervet: No, it isn't. There's an incomplete attempt in https://github.com/jskeet/sdk-csharp/tree/aot - it's possible that we could do this incrementally, but for the moment I'm afraid I don't have time to put into it. @captainsafia has expressed interest though, and can probably do a better job on this than I can anyway.

jskeet avatar Aug 21 '24 14:08 jskeet

Thank you @jskeet for your "very" quick answer.

guillaume-chervet avatar Aug 21 '24 15:08 guillaume-chervet