cloudera-scripts-for-log4j icon indicating copy to clipboard operation
cloudera-scripts-for-log4j copied to clipboard

missing parameter in find

Open sigpet opened this issue 3 years ago • 3 comments

https://github.com/cloudera/cloudera-scripts-for-log4j/blob/main/cm_cdp_cdh_log4j_jndi_removal.sh#L63 it's missing the -name parameter after -o

line should read for tarfile in $(find -L $targetdir -name ".tar.gz" -o -name ".tgz"); do

I fixed it locally and the find does not error any more

sigpet avatar Dec 21 '21 15:12 sigpet

Thank you, fixed.

isuller avatar Dec 22 '21 06:12 isuller

It seems fixed by commit https://github.com/cloudera/cloudera-scripts-for-log4j/commit/f27791387d3e767e6688bb649df9994c211221c1 why has the github issue not been closed ?? ( need to keep the list of issues and PRs as clean as possible , it started to get messy )

lhoss avatar Dec 27 '21 11:12 lhoss

@lhoss I don't have the right to close an issue - don't know who can. Maybe @sunilgovind knows?

isuller avatar Dec 31 '21 08:12 isuller