amqp-client.js icon indicating copy to clipboard operation
amqp-client.js copied to clipboard

Fix return type in AMQPConsumer constructor

Open JoshJarabek7 opened this issue 2 years ago • 1 comments

Originally only had void as the return type, and the example on the README.md showed a Promise being returned, causing yellow squiggles from Typescript / Sonarlint.

JoshJarabek7 avatar Sep 27 '23 20:09 JoshJarabek7

Isn't that because your onMessage callback returns a Promise. In that case I guess we should change to any in the lib since we can't control what users of the lib return in their callbacks. Or the lib should handle async callbacks.. WDYT @carlhoerberg?

baelter avatar Sep 28 '23 06:09 baelter