ansible-prometheus icon indicating copy to clipboard operation
ansible-prometheus copied to clipboard

Remove unnecessary dependency on jmespath

Open flowerysong opened this issue 4 years ago • 10 comments

This is fairly straightforward manipulation to do with standard Jinja features, there's no need to use a non-default library.

flowerysong avatar Oct 11 '21 19:10 flowerysong

upvote, let's wait and see, tbh, i gotta manually add ansible.builtin.pip for this jmespath in my playbook, what a pain. haha

piengeng avatar Oct 12 '21 14:10 piengeng

This needs a rebase to get the tests to pass.

SuperQ avatar Jan 23 '22 17:01 SuperQ

Or, maybe something else is broken. :frowning_face:

SuperQ avatar Jan 23 '22 17:01 SuperQ

Ahh, I think I see what's going on. molecule is not creating the role symlink because it's a PR from a fork. Boo.

SuperQ avatar Jan 23 '22 17:01 SuperQ

Or, maybe something else is broken.

This is a brief window of time during which the latest newest ansible-compat is broken.
Change test-requirements.txt:

# temporarily lock versions of molecule and ansible-compat to avoid a bug:
ansible-compat==0.5.0
molecule==3.5.2

sdarwin avatar Jan 23 '22 17:01 sdarwin

Ok, fixed HEAD. Please rebase again.

SuperQ avatar Jan 23 '22 18:01 SuperQ

@SuperQ Looking a little better, but it's still complaining about the Mergify configuration, and I'm not sure what's up with the failure for test-2.9-default.

flowerysong avatar Jan 23 '22 21:01 flowerysong

  • mergify strict mode is end-of-life
  • circleci config file, should run on large instances. resource_class: large

sdarwin avatar Jan 23 '22 22:01 sdarwin

@sdarwin Thanks, looks like we need to update the Mergify config in the auto-maintenance repo.

SuperQ avatar Jan 24 '22 13:01 SuperQ

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 11:04 stale[bot]

This role has been deprecated in favor of a the prometheus-community/ansible collection.

SuperQ avatar Mar 06 '23 15:03 SuperQ