ansible-prometheus icon indicating copy to clipboard operation
ansible-prometheus copied to clipboard

Allow texteditors highlight rules based on extention

Open freeseacher opened this issue 5 years ago • 2 comments

What is missing? For now alerts have to be with extension .rules https://github.com/cloudalchemy/ansible-prometheus/blob/015db753b1ab334a6669b3045c125088bfb4c5ef/templates/prometheus.yml.j2#L21

that disables syntax highlight for most text editors. Please change it to *.rules.yml

Why do we need it? It looks like basic user attention.

freeseacher avatar Feb 18 '20 16:02 freeseacher

probably introducing default with that kind of line prometheus_rule_files: "{{ prometheus_config_dir }}/rules/*.rules" looks like reasonable solution

freeseacher avatar Feb 18 '20 16:02 freeseacher

That makes sense to me. Maybe we can provide both for backwards compatibility? Can you create PR?

paulfantom avatar Mar 06 '20 12:03 paulfantom

This role has been deprecated in favor of a the prometheus-community/ansible collection.

SuperQ avatar Mar 06 '23 15:03 SuperQ