ansible-grafana icon indicating copy to clipboard operation
ansible-grafana copied to clipboard

Allow overriding grafana_package from vars

Open kunickiaj opened this issue 3 years ago • 8 comments

Conditionally import default os-specific package names if grafana_package isn't explicitly set.

Updates the molecule alternative tests to use the grafana-enterprise repo to allow for also verifying that overriding grafana_package to grafana-enterprise works.

Resolves #228


This change is Reviewable

kunickiaj avatar Sep 04 '20 17:09 kunickiaj

This was the cleanest way I could come up with, but if there's a better way you can think of I'll welcome it.

kunickiaj avatar Sep 04 '20 17:09 kunickiaj

The linter issues failing CI are not files I've changed. Also noted in local testing that everything works except centos8 which seems to be unrelated:

fatal: [centos8]: FAILED! => {"attempts": 5, "changed": false, "msg": "Failed to validate GPG signature for libSM-1.2.3-1.el8.x86_64"}

kunickiaj avatar Sep 04 '20 19:09 kunickiaj

Could you rebase it so CI can test this PR?

paulfantom avatar Sep 17 '20 06:09 paulfantom

This still looks like the centos8 failure with

Failed to validate GPG signature for libSM-1.2.3-1.el8.x86_64

Not sure what that's about but I don't believe its related to this change.

kunickiaj avatar Sep 21 '20 16:09 kunickiaj

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 16 '20 03:11 stale[bot]

Will try to rebase this again if the centos8 issue has been resolved.

kunickiaj avatar Nov 16 '20 17:11 kunickiaj

It looks like the centos8 issue is still present.

kunickiaj avatar Nov 16 '20 17:11 kunickiaj

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 18 '22 15:04 stale[bot]

This role has been deprecated in favor of a the prometheus-community/ansible collection.

SuperQ avatar May 31 '23 04:05 SuperQ