coredns_mysql icon indicating copy to clipboard operation
coredns_mysql copied to clipboard

Have you considered a common backend.go method?

Open GitHub-huyuan opened this issue 2 years ago • 3 comments

It feels like it could be similar to etcd, which implements the ServiceBackend interface.Is there a problem?

GitHub-huyuan avatar Nov 14 '23 02:11 GitHub-huyuan

Can you elaborate please?

khash avatar Nov 16 '23 19:11 khash

There is a backend.go file in the plugin directory that defines the ServiceBackend interface, so why don't we implement the methods in this interface? I don't know if I've made myself clear, what I'm asking is why you don't abstract into this interface form

GitHub-huyuan avatar Nov 22 '23 03:11 GitHub-huyuan

I see. This plugin is a modified version of the Redis one which doesn't use the interface. Perhaps the interface is a newer abstraction that was introduced after the Redis plugin.

khash avatar Nov 22 '23 16:11 khash