fuse-backend-rs icon indicating copy to clipboard operation
fuse-backend-rs copied to clipboard

fuse_t_session: Correctly handle EOF

Open griff opened this issue 1 year ago • 5 comments

The fuse-t session uses a socket pair for communication but wasn't correctly handling EOF and so when trying to gracefully unmount it would just hang. This change simply deals with EOF in the channel and returns None when it occurs during header read and an error otherwise.

griff avatar Sep 29 '23 15:09 griff

lgtm, but please cargo fmt your code, thanks!

bergwolf avatar Oct 10 '23 07:10 bergwolf

lgtm, but please cargo fmt your code, thanks!

Done

griff avatar Oct 11 '23 13:10 griff

Still failing. You can run make check locally.

bergwolf avatar Oct 13 '23 09:10 bergwolf

I have now run the check locally and fixed the issues found there.

griff avatar Oct 13 '23 11:10 griff

@griff

test macfuse_tests::integration_test_macfuse_hello has been running for over 60 seconds

I tried it locally and got the same results. Please help to fix it. You can reproduce by running make smoke-macos locally.

bergwolf avatar Oct 30 '23 04:10 bergwolf