Branches that contain "=" do not build successfully and do not show up in the build history

[davemcorwin]

trafficstars

User Story

Branches that contain = or # do not build successfully and do not show up in the build history for the repo. It's possible that this could extend to any character that needs to be URL encoded and/or we need to revisit the allowed characters for branches.

Background (Optional)

The example was https://github.com/18F/samhsa-prototype/tree/dc-482%3Dfacility-map-link which has since been closed.

Acceptance Criteria

• [ ] Branches with branch names that contain =, #, and/or other characters that must be URL encoded should build and be available like other branches.
• [ ] Fail builds and update build status message that Branches with branch names that contain =, #, and/or other characters that must be URL encoded should build and be available like other branches
• [ ] Change made live via <TODO>.

After evaluating, edit this part:

Level of effort - <low/medium/high>

Implementation outline (if higher than "low" effort):

• [ ] <TODO>

[amirbey]

This fails validation in the sequelize model and the build is not created in the build table. This has also been seen with apostrophes in the branch name: https://gsa-tts.slack.com/archives/C1NUUGTT5/p1588104161160600

Since the branch is part of the preview url, urls also need to be modified/encoded to work.