cg-style icon indicating copy to clipboard operation
cg-style copied to clipboard

remove package-lock.json from repository, as this code is consumed as a package

Open afeld opened this issue 6 years ago • 3 comments

afeld avatar Sep 09 '19 14:09 afeld

@afeld I'm not a JS person, but isn't package-lock.json also used for this code's internal dependency packaging? I don't think we can remove it.

siennathesane avatar Sep 09 '19 16:09 siennathesane

No, it would only be used when running npm install from within this repository specifically.

One key detail about package-lock.json is that it cannot be published, and it will be ignored if found in any place other than the toplevel package.

https://docs.npmjs.com/files/package-lock.json

Ongoing thread in Slack

afeld avatar Sep 09 '19 17:09 afeld

Is it breaking something downstream?

siennathesane avatar Sep 09 '19 18:09 siennathesane