e2e-benchmarking icon indicating copy to clipboard operation
e2e-benchmarking copied to clipboard

Replace `kube_deployment_labels` and `kube_replicaset_labels` with `k…

Open akrzos opened this issue 7 months ago • 2 comments

…ube_deployment_spec_replicasandkube_replicaset_spec_replicas`

Type of change

  • Bug fix

Description

Both metrics kube_deployment_labels and kube_replicaset_labels are no longer available in OCP prometheus, instead we can get the counts of deployments from kube_deployment_spec_replicas and the counts of ReplicaSets from kube_replicaset_spec_replicas

akrzos avatar May 14 '25 20:05 akrzos

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akrzos Once this PR has been reviewed and has the lgtm label, please assign krishvoor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 14 '25 20:05 openshift-ci[bot]

Hi @akrzos. Thanks for your PR.

I'm waiting for a cloud-bulldozer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar May 14 '25 20:05 openshift-ci[bot]