Christo Lolov

Results 50 comments of Christo Lolov

I am aware checkstyle is complaining about some indentation which I will fix later throughout the day.

Hey @dplavcic, thank you for the comments. I will aim to provide an answer in the next couple of days!

Heya @cadonna and thank you very much for the review! I will address your comments over the next few days.

Hello @cadonna. Apologies, I am back on having bandwidth to move this (and the rest of the pull requests) to a conclusion. I will post an update later today.

The build is failing because of checkstyle problems: ``` [2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentSessionStoreTest.java:268:17: Variable 'inOrder' should be declared final. [FinalLocalVariable] [2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentSessionStoreTest.java:279:17: Variable 'inOrder' should be declared final....

Yay 🎉 , thank you for your help in reviewing, approving and merging this @cadonna!

Hello @cadonna, I have rebased the pull request.

Hello @dplavcic and @cadonna, how is this pull request fairing? Is there something outstanding as a review or comments to be addressed?

Hello @dongjinleekr! What is the current state of this pull request?

Hello @mdedetrich and @cadonna! Is there something still remaining for this pull request or are we ready to merge it? There are around 4 pull requests remaining of this migration...