protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard
verified publisher icon clojusc

Provide full support for proto3

Open oubiwann opened this issue 7 years ago • 7 comments

Tasks:

  • [x] Add proto3 examples
  • [ ] Add proto3 tests
  • [ ] Add proto3 support for default value in enums - #30
  • [x] Add support for extracting the syntax of any given message
  • [x] Update Travis CI config to support proto3 on Travis builds (Travis Ubuntu containers currently only support 3)

oubiwann avatar Jul 03 '18 04:07 oubiwann

There's a proto3 example here:

  • https://github.com/google/protobuf/blob/master/examples/addressbook.proto

Update: Added.

oubiwann avatar Jul 13 '18 03:07 oubiwann

The more I read about proto3, the less I like it :-( The changes were pretty drastic, from the perspective of schema-based data applications (or RPC services). I may end up back-burnering this task. I'd accept a PR for a good solution that didn't effect the usability of proto2 ...

oubiwann avatar Jul 14 '18 07:07 oubiwann

I guess I should claify that last comment:

  1. I'm still working on supporting proto3 ;-)
  2. The comment was made after exploring the possibility of converting everything to proto3, since it and proto2 are wire-compatible ...
  3. The explorations were a dismal failure, and I did a lot of reading to learn more about all the changes between versions and their implications, in an effort to determine a level of effort in moving everything in this project to proto3 ...

On a side note, I did come across Cap'n Protocol (by the author of Protocol Buffers v2), and that looks really nice; too bad Google won't adopt it :-(

oubiwann avatar Jul 14 '18 15:07 oubiwann

This is a great expansion of the flatland impl. The interface is simple as expected. Thanks for the work on this!

I'm experiencing something that may be attributable to this issue/epic - when I deserialize proto3 schemas that have enums with 0 vals, the enum seems to just drop out of the message. Is this expected until proto3 is fully supported?

Thanks again for the library!

mattyulrich avatar Sep 27 '18 03:09 mattyulrich

Hi, is there any update?

smessems avatar Nov 15 '18 14:11 smessems

Sadly, no :-(

I don't suspect I'll have the time to work on proto3 any time in the near future, so this will likely need to be a community contribution/PR.

It's an interesting problem to tackle; wish I had more availability for it.

oubiwann avatar Nov 15 '18 14:11 oubiwann

Thanks. Would it be possible to maybe lay out some info you gained while investigating this?

smessems avatar Nov 16 '18 06:11 smessems