elastisch icon indicating copy to clipboard operation
elastisch copied to clipboard

Enable the use of Elastic Shield

Open devth opened this issue 8 years ago • 9 comments

https://www.elastic.co/guide/en/shield/current/_using_elasticsearch_java_clients_with_shield.html

devth avatar Jul 08 '16 15:07 devth

i'll digg into that;

timgluz avatar Oct 29 '16 14:10 timgluz

Hi,

I'm almost done with this task, but I have a few question before i start preparing PR. Is it fine to add the additional dependency for the Shield plugin? If not, should I publish it as a separate package?

timgluz avatar Dec 18 '16 12:12 timgluz

@timgluz most likely it is, can you elaborate? Is it an open source client library from Elastic? under what license?

michaelklishin avatar Dec 18 '16 13:12 michaelklishin

Looks like it has a library part but is not open source. I cannot find any license or usage information. If so, it should be an optional dependency (e.g. something that applications list as dependencies if they want to use Shield). We can also consider making it a separate ClojureWerkz project.

michaelklishin avatar Dec 18 '16 13:12 michaelklishin

Yes, it's a proprietary extension, managed and owned by Elastic and first install includes only 30days trial; source

That's why I am thinking of creating a new project clojurewerkz.elastisch.shield, which could be added as the additional dependency if people want to work with the shield. And another reason is testing - it requires own separate Docker image with custom configuration for users and roles;

timgluz avatar Dec 18 '16 14:12 timgluz

@timgluz alright. Should I set up a new ClojureWerkz repo for you then?

michaelklishin avatar Dec 18 '16 17:12 michaelklishin

Yes, please;

timgluz avatar Dec 18 '16 17:12 timgluz

@timgluz done: https://github.com/clojurewerkz/elastisch.shield. I'm making sure you have push permissions now.

One question I have w.r.t. Shield support is how we are going to do integration testing if it's a commercial plugin. Not having tests really sucks.

michaelklishin avatar Dec 18 '16 18:12 michaelklishin

Thanks!

I'm adding tests for all the new functionalities and i'm also going to re-use tests from elastisch to test that the Shield clients work as rest-client and native-client.

I'm also going to set up travis for the new project;

timgluz avatar Dec 18 '16 18:12 timgluz