clojure-lsp icon indicating copy to clipboard operation
clojure-lsp copied to clipboard

Rename namespaces could rename explicitly qualified keywords in edn files

Open mynomoto opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. When renaming a namespace clojure-lsp doesn´t rename explicit qualified keywords on edn files. E.g. If i do a namespace renaming from foo.bar to bar.baz clojure-lsp do not change explicit keywords from :foo.bar/x to :bar.baz/x.

Describe the solution you'd like clojure-lsp renames :foo.bar/x to :bar.baz/x in edn files when the namespace is renamed.

Describe alternatives you've considered I could rename it myself manually but it is not great. I could write a tool to do it but clojure-lsp is great and does almost what I want.

Additional context This is like #573 but for edn files.

mynomoto avatar Sep 24 '21 11:09 mynomoto

@borkdude is there any way to get analysis for edn files?

ericdallo avatar Sep 24 '21 12:09 ericdallo

@ericdallo I guess we could. EDN is currently handled in the clj-kondo/impl/analyzer/usages namespaces. Not sure what we do with EDN, perhaps we just skip it. So we would need to do some more analysis if analysis is enabled.

borkdude avatar Sep 24 '21 12:09 borkdude