liberator icon indicating copy to clipboard operation
liberator copied to clipboard

Tutorial out-of-date

Open xukai92 opened this issue 7 years ago • 10 comments

I believe the tutorial here: https://clojure-liberator.github.io/liberator/tutorial/getting-started.html is very old. Any plan to update it for the benefit of beginners (like me)?

xukai92 avatar May 06 '17 01:05 xukai92

What parts do you think are outdated?

ordnungswidrig avatar May 06 '17 20:05 ordnungswidrig

For example versions are outdated

Library Tutorial Current
liberator 0.13 0.15.1
compojure 1.3.4 1.6.0
ring 1.2.1 1.6.3

And also it's worth checking how liberator works with Clojure 1.9, when I tested with the beta versions there were some problems.

jjhop avatar Dec 10 '17 15:12 jjhop

I've been using Liberator with the 1.9 alphas, betas and RC's all along and haven't seen any issues. What did you see @jjhop ?

belucid avatar Dec 10 '17 16:12 belucid

Hi @belucid

I've checked again what was the problem. But... there are no problem. My fault, sorry. The problem (also a little) was with kormasql @1.9RC1

jjhop avatar Dec 11 '17 21:12 jjhop

No worries, good to know you didn't find any hidden 1.9 issues. Let's not hijack the issue any longer though, still good to get the tutorial versions up to date.

belucid avatar Dec 11 '17 21:12 belucid

@belucid I could take care of it (and check if these current versions do not cause problems).

jjhop avatar Dec 12 '17 10:12 jjhop

I'd appreciate a PR to get the tutorial to modern clojure age very much :)

ordnungswidrig avatar Dec 12 '17 12:12 ordnungswidrig

Regarding 1.9 please feel free to open an issue to track any upcoming related obstacles.

ordnungswidrig avatar Dec 12 '17 12:12 ordnungswidrig

Ok, I'll take it.

jjhop avatar Dec 12 '17 12:12 jjhop

@ordnungswidrig pr ready to review/merge

jjhop avatar Dec 12 '17 23:12 jjhop