cider icon indicating copy to clipboard operation
cider copied to clipboard

Cider-find-dwim doesn't recognize symbols with ? and ! marks

Open introom opened this issue 5 years ago • 3 comments

On a symbol name teardown!, cider-find-dwim will recoganize it as teardown. This happens for symbols ending with ? too.

introom avatar Jul 13 '20 13:07 introom

This appears to be from cider--find-dwim-interactive which calls (thing-at-point 'filename) to attempt to resolve the symbol-or-file.

thingatpt.el in turn defines a filename to be

(defvar thing-at-point-file-name-chars "-@~/[:alnum:]_.${}#%,:"
  "Characters allowable in filenames.")

which is strange because filenames can contain a much wider range of characters (including ? and !).

A solution could be to disambiguate symbols and files based on whether the point is in a string? I can't see why filenames in code would ever be represented as anything besides a string (or maybe a comment). cider-symbol-at-point would then work for symbols with special characters.

yuhan0 avatar Aug 27 '20 16:08 yuhan0

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

stale[bot] avatar Nov 26 '20 21:11 stale[bot]

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

stale[bot] avatar Dec 28 '20 18:12 stale[bot]