cider icon indicating copy to clipboard operation
cider copied to clipboard

Notify users when some command is not supported under ClojureScript

Open bbatsov opened this issue 7 years ago • 9 comments

Right now often people experience weird issues when they try to run something supported only for Clojure in a ClojureScript connection. It'd be nice if we added some basic function that does sanity checking in such commands and informs the users that the command they won't to use is not yet supporting "ClojureScript". Back in the day we've added some check only for the debugger, but it's time to expand this.

This command should be pretty easy to implement and should be applied to common interactive commands.

Any volunteers to take a stab at it? @xiongtx @ckoparkar @dpsutton

bbatsov avatar Feb 06 '18 01:02 bbatsov

I'll be happy to take a look at this in the next few days.

ckoparkar avatar Feb 06 '18 13:02 ckoparkar

Update: Started looking at this yesterday. Will post a PR before the weekend.

ckoparkar avatar Feb 14 '18 13:02 ckoparkar

Awesome!

bbatsov avatar Feb 14 '18 13:02 bbatsov

@ckoparkar How's that PR coming along?

bbatsov avatar Feb 27 '18 03:02 bbatsov

Sorry, got distracted with other things :( Will finish this up soon.

ckoparkar avatar Feb 27 '18 20:02 ckoparkar

No problem!

bbatsov avatar Mar 04 '18 13:03 bbatsov

@ckoparkar Any progress with this? I hope to push a new release out in about 2 weeks and it'd be awesome if this is part of it.

bbatsov avatar Apr 02 '18 06:04 bbatsov

Huh, it's been 2 months since my first comment. Really sorry for squatting on this for so long. Unfortunately, I din't get a lot of time to work on this :(

@dpsutton @xiongtx does this sound like something you'd like to pick up? If not, I'm going to try and finish it up over the weekend. I'd hate for this to miss the release.

ckoparkar avatar Apr 04 '18 15:04 ckoparkar

@ckoparkar I'm fine with waiting till the weekend.

bbatsov avatar Apr 04 '18 17:04 bbatsov