cider icon indicating copy to clipboard operation
cider copied to clipboard

Switching to REPL splits window horizontally

Open ftravers opened this issue 7 years ago • 5 comments

Expected behavior

When starting or switching to the repl, it should open in that last used already open window.

Actual behavior

Now it splits your current window in half horizontally.

Steps to reproduce the problem

Have two windows open vertically. Start the repl (jack-in). The window you are already in will be split in two horizontally.

Environment & Version information

CIDER version information

;; CIDER 0.17.0snapshot (package: 20180121.1106), nREPL 0.2.13 ;; Clojure 1.9.0, Java 1.8.0_144

Lein/Boot version

% lein --version
Leiningen 2.8.1 on Java 1.8.0_144 OpenJDK 64-Bit Server VM

Emacs version

GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26) of 2017-12-05

Operating system

Arch linux, up-to-date.

ftravers avatar Jan 22 '18 12:01 ftravers

Is this a feature request or a bug report? I thought right now the current code decided what to do based on the size of the Emacs window.

bbatsov avatar Jan 22 '18 12:01 bbatsov

Sorry bug report...hmmm... i just moved to a 43" tv screen...so maybe that's why I'm seeing the difference... It is annoying to have extra windows opened up, as I keep having to delete the extra windows. Whereas, I guess with the smaller screen, this didn't happen, so wasn't having to sort the windows all the time. BTW: 4K TV pretty awesome to code with.

ftravers avatar Jan 22 '18 12:01 ftravers

Pretty sure that's the case indeed. I guess we can add some config to force a certain type of window splitting regardless of the screen size.

bbatsov avatar Jan 22 '18 13:01 bbatsov

Yes, that would be amazing!

ftravers avatar Jan 22 '18 23:01 ftravers

Maybe I misunderstand the ticket but thought this was what split-witdth-threshold and split-height-threshold is for.

benedekfazekas avatar Apr 09 '18 14:04 benedekfazekas