cider icon indicating copy to clipboard operation
cider copied to clipboard

Instrumented face is not cleared in the REPL when you remove instrumentation

Open bbatsov opened this issue 9 years ago • 5 comments

That's a relatively small bug, but it's also kind of annoying that the special font-locking never goes away from functions that were already evaluated in the REPL.

Expected behavior

After removing debug instrumentation this should affect functions that were already executed in the REPL.

Actual behavior

This doesn't happen.

image

Steps to reproduce the problem

  1. Instrument some function.
  2. Execute it in the REPL
  3. De-instrument the function.

Environment & Version information

CIDER version information

; CIDER 0.11.0snapshot (package: 20151112.1551) (Clojure 1.7.0, nREPL 0.2.12)

Emacs version

24.5

Operating system

OS X El Capitan

bbatsov avatar Feb 28 '16 09:02 bbatsov

Hm. I see why that would happen, but I don't think it has an easy fix. The REPL specifically avoids font locking stuff above the most recent prompt. So any previous inputs are sort of frozen in time. :-)

Malabarba avatar Feb 28 '16 14:02 Malabarba

I actually think there's an easy fix - we can just strip such faces before freezing the input.

bbatsov avatar Feb 28 '16 18:02 bbatsov

Sounds reasonable. 👍

Malabarba avatar Feb 28 '16 21:02 Malabarba

@Malabarba Any :game_die: you can take a look at this?

xiongtx avatar Mar 14 '18 08:03 xiongtx

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

stale[bot] avatar May 08 '19 18:05 stale[bot]