cider-nrepl icon indicating copy to clipboard operation
cider-nrepl copied to clipboard

Stacktrace at point or in region

Open r0man opened this issue 3 years ago • 1 comments

This PR adds Stacktrace at point or in region support.

Please see: https://github.com/clojure-emacs/orchard/pull/164


Before submitting a PR make sure the following things have been done:

  • [x] The commits are consistent with our contribution guidelines
  • [x] You've added tests to cover your change(s)
  • [ ] All tests are passing
  • [ ] The new code is not generating reflection warnings
  • [ ] You've updated the README (if adding/changing middleware)

r0man avatar Sep 18 '22 18:09 r0man

Looks good, failing CI aside.

bbatsov avatar Sep 19 '22 05:09 bbatsov

@bbatsov @vemv This one would be ready from my side.

r0man avatar Nov 26 '22 12:11 r0man

After merging it I noticed we forgot to update the changelog.

bbatsov avatar Nov 26 '22 21:11 bbatsov

It also seems to me you've updated ops.adoc manually, instead of generating it from the middleware descriptors. This will have to be fixed, otherwise your nice docs will disappear once this is regenerated with the lein docs task.

bbatsov avatar Nov 26 '22 21:11 bbatsov

Oops, I opened another PR to address those issues: https://github.com/clojure-emacs/cider-nrepl/pull/762

r0man avatar Nov 27 '22 09:11 r0man