cider-nrepl icon indicating copy to clipboard operation
cider-nrepl copied to clipboard

Documentation of `retest` doesn't seem correct?

Open marcomorain opened this issue 4 years ago • 2 comments

The documentation of the retest command doesn't seem correct.

Return exception cause and stack frame info for an erring test via the stacktrace middleware. The error to be retrieved is referenced by namespace, var name, and assertion index within the var.

The Cider docs say this:

Re-run test failures/errors.

The retest will re-run any tests that failed in the previous test run, right?

marcomorain avatar Dec 13 '21 11:12 marcomorain

Right, retest does exactly the following:

https://github.com/clojure-emacs/cider-nrepl/blob/a898e40b5dca44e34c0df80a8aeb48b05143f543/src/cider/nrepl/middleware/test.clj#L352-L368

The most relevant bit being (test-nss ,,,.

Which contradicts https://docs.cider.mx/cider-nrepl/nrepl-api/ops.html#retest and indeed seems worth fixing.

vemv avatar Dec 13 '21 14:12 vemv

Seems we made a classic copy/paste mistake. :-)

bbatsov avatar Dec 21 '21 08:12 bbatsov

Fixed recently

vemv avatar Jul 21 '23 10:07 vemv