SpacetimeDB icon indicating copy to clipboard operation
SpacetimeDB copied to clipboard

Enhance exception message in update_bulk_unique_0_u32_u64_u64 method

Open ch4r1ty opened this issue 10 months ago • 2 comments

  • Improved the exception message in the update_bulk_unique_0_u32_u64_u64 method to provide more detailed information about the discrepancy between expected and actual row counts. This enhancement will aid in debugging and understanding issues related to insufficient rows during bulk updates.

Description of Changes

Improved the exception message in the update_bulk_unique_0_u32_u64_u64 method within the synthetic.cs file. The updated exception message now provides detailed information about the discrepancy between expected and actual row counts. This enhancement will assist in debugging and understanding issues related to insufficient rows during bulk updates.

API and ABI breaking changes

This change does not involve any API or ABI breaking modifications.

Expected complexity level and risk

Complexity Level: 1

This change is a simple string update and does not have complex interactions with existing or future code.

Testing

Completed Tests:

  • Verified that the exception message displays correctly when there are insufficient rows. Reviewer Tests:

  • Confirm that the exception message accurately reflects the expected and actual row count differences under various conditions.

ch4r1ty avatar Mar 12 '25 00:03 ch4r1ty

Hey @ch4r1ty ! Thanks for opening this. Since the benchmarks are currently part of the main SpacetimeDB repo, we ask contributors to sign our Contributor License Agreement (CLA) before we merge their changes.

If you're willing to sign our CLA, could you send an email to [email protected]? After that, this PR LGTM :slightly_smiling_face: )

bfops avatar Apr 04 '25 18:04 bfops

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 03 '25 18:05 CLAassistant