Remove row deduplication in incremental update

Open joshua-spacetime opened this issue 10 months ago • 1 comments

The server deduplicates rows for incremental join updates before sending the updated rows to the client.

https://github.com/clockworklabs/SpacetimeDB/blob/74661be0c296e52afb32c7a3669d56e536558875/crates/core/src/subscription/delta.rs#L15-L17

This is a bug.

It was necessary at the time it was introduced because the client SDKs did not handle duplicate rows. The SDKs were eventually updated to handle duplicate rows, but the deduplication on the server was never removed.

This has the potential to result in a corrupted SDK client cache for join subscriptions.

Mar 07 '25 23:03 joshua-spacetime

While I don't know the exact query responsible, I believe this to be a manifestation of the bug.

Mar 07 '25 23:03 joshua-spacetime