WIP v9 validation code

Open kazimuth opened this issue 1 year ago • 3 comments

Description of Changes

WIP validation code for moduledefv9, plus the definition for ModuleDef. The new module-def should also be backwards-compatible with V8BackCompat and the existing TableSchema, Header, etc types. I have not implemented those bridges yet.

API and ABI breaking changes

A few API changes in components I have recently added, otherwise this is just adding code.

Expected complexity level and risk

1, there is a good amount of code but I am generally happy with the redesigned interfaces. It's fun playing with my new multi-error combinator.

Testing

Test porting is WIP, I have more proptest helpers now and I am going to use those to fuzz this once I've got the rest of the stuff ported.

Aug 07 '24 05:08 kazimuth

@Centril @cloutiertyler This is ready for review.

Aug 09 '24 05:08 kazimuth

I didn't touch C#, so not sure where those SDK failures are coming from.

Aug 09 '24 06:08 kazimuth

@Centril, please review #1584, #1585, #1586 before coming back to this one.

Aug 13 '24 20:08 kazimuth

@Centril @cloutiertyler I consider this ready for merge.

Aug 23 '24 23:08 kazimuth