SpacetimeDB icon indicating copy to clipboard operation
SpacetimeDB copied to clipboard

add test test_multi_column_two_ranges, which should fail but doesn't

Open Centril opened this issue 1 year ago • 2 comments

Description of Changes

Please describe your change, mention any related tickets, and so on here.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected!

  • [x] Write a test you've completed here.
  • [ ] Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

Centril avatar May 15 '24 20:05 Centril

  1. Test doesn't demonstrate that the query actually uses the index.
  2. Test doesn't demonstrate that query correctly selects only rows within both ranges, not e.g. { a: 4, b: 7 }.

gefjon avatar May 15 '24 23:05 gefjon

@gefjon the point of the test is to show that the current implementation is wrong. This PR will be morphed into a fix and the test will of course be adjusted to show that an index is not used.

Centril avatar May 16 '24 00:05 Centril

Closing this as it is being fixed in https://github.com/clockworklabs/SpacetimeDB/pull/1316 instead.

DO NOT DELETE THE BRANCH

Centril avatar May 30 '24 12:05 Centril