packages icon indicating copy to clipboard operation
packages copied to clipboard

[react-leaflet] Make core API accessible

Open bgalartza opened this issue 3 years ago • 1 comments

The version has been tested and used in production for several months, but as it's the first time creating a package of this type (using npm) a review would be appreciated. Thank you in advance.

bgalartza avatar Aug 05 '21 15:08 bgalartza

Hmm, is there really some part of react-leaflet API that is completely inaccessible through the official UMD JS file? That's unfortunate. I'd really prefer using the existing files whenever possible.

I don't have any projects using this myself but I'm asking a co-worker if we still have some other projects using cljsjs instead of shadow-cljs.

Deraen avatar Sep 22 '21 07:09 Deraen

As far as we could see the core api which is used to extend the functionality of the library is not available in the main UMD JS file. But after re-reading the documentation it looks like it's distributed in a separated package(which is a dependency of the main one, but apparently not included in the main JS file).

For the new 4.x versions they have changed the way they distribute the library. We will revisit the topic once we decide to update the library in our projects and make a new PR with a detailed explanation of our findings.

In the meantime I'm closing the issue. Thank you for your time.

bgalartza avatar Sep 23 '22 07:09 bgalartza