Breaking changes for v2.0
A wishlist of breaking changes for the next major version:
- [ ] Change return types so that we can fix the cargo clippy pedantic warnings, like
casting `i64` to `usize` may lose the sign of the valueorcasting `usize` to `u32` may truncate the value on targets with 64-bit wide pointers - [ ] Introduce intermediary types so that we could write
M::up(…).hook(…).down(…).hook(…) - [ ] Remove deprecated items
Other things to decide on:
- [ ] Remove
Eqimplementation onM#45 - [ ] Remove
PartialEqfrom ourErrortype?
I don’t know if a breaking version will ever be released though, there are costs to forcing users to migrate.
We can probably also remove PartialEq from our Error implementation.
Maybe also migrate to thiserror?
We can probably also remove
PartialEqfrom ourErrorimplementation.
That’s a good point, I’ve added it to the checklist at the top.
Maybe also migrate to
thiserror?
What prevents us from doing it? We could do it in a way that doesn’t break the API compatibility, couldn’t we?
What prevents us from doing it? We could do it in a way that doesn’t break the API compatibility, couldn’t we?
I believe so, we can create a task for that if we deem it worthwhile.
I’ve created #95 for this.