useful icon indicating copy to clipboard operation
useful copied to clipboard

Use java.util.Base64 instead of BASE64Encoder

Open danielcompton opened this issue 6 years ago • 3 comments

For backwards/forwards compatibility between implementations, adds a trailing newline to the string to match the behaviour of the sun.misc.BASE64Decoder.

This effectively sets the minimum JVM to Java 8, at least to use this namespace.

danielcompton avatar Dec 06 '18 10:12 danielcompton

Based on data from the 2018 State of Clojure (almost a year ago), 93% of the community was using Java 8 or higher. I expect that number is higher now.

puredanger avatar Dec 06 '18 22:12 puredanger

Thanks @puredanger that's very helpful information. I had thought about asking a question on the mailing list but had forgotten about the survey data. I'm leaning towards merging this then, but will give it a little bit more time for others to comment also.

danielcompton avatar Dec 06 '18 22:12 danielcompton

If this is going to be merged, can the existing reliance on the sun.misc.* stuff be removed? While it's still in, the library is unusable from java 11+.

NoahTheDuke avatar Aug 12 '23 03:08 NoahTheDuke