kibit icon indicating copy to clipboard operation
kibit copied to clipboard

Published 20 hours ago • verified publisher icon clj-commons

Suggest when-not for if-not with single branch

Open bbakersmith opened this issue 9 years ago • 3 comments

bbakersmith avatar Dec 30 '15 04:12 bbakersmith

Hey, is this still ok to merge? What was the reason for closing?

danielcompton avatar Jan 04 '16 23:01 danielcompton

I personally find this more clear, but I wasn't sure if there was consensus around this convention. Added a commit for the positive check as well and reopened. It's good to merge if you agree with the recommendation.

bbakersmith avatar Jan 05 '16 01:01 bbakersmith

Similarly to #2, there isn't complete consensus around this. Being able to specify which rules are included will be helpful. I'll have a think about whether to merge this now, or once that is in. Thanks!

danielcompton avatar Jan 10 '16 20:01 danielcompton