hickory icon indicating copy to clipboard operation
hickory copied to clipboard

properly deal with reflection warning

Open erdos opened this issue 7 months ago • 1 comments

Followup to PR https://github.com/clj-commons/hickory/pull/92/files

Function hickory.core/parse calls Jsoup.parse unary method. In current JSoup version 1.20.1 it is overloaded for File, String and Path classes.

Current implementation uses reflection to dispatch to the correct overloaded method implementation. However, proper approach would be dispatching based on type, and I took inspiration from https://github.com/dakrone/clj-http/pull/650 for this change.

erdos avatar May 24 '25 18:05 erdos

I'm fine with this change. You too @slipset ? I also bumped Jsoup to 1.21.1 now on master. We could do a release after this one is merged.

borkdude avatar Jun 24 '25 12:06 borkdude