dirigiste icon indicating copy to clipboard operation
dirigiste copied to clipboard

Question: Is there a reason why threads are not created as daemon?

Open eric opened this issue 8 years ago • 2 comments

It seems that dirigiste is causing my java processes to not exit and I noticed that threads are not being started as daemon threads. Is that intentional? Is there something I should do to make my process exit nicely?

eric avatar May 27 '16 22:05 eric

You can specify a ThreadFactory, but I agree that daemon threads could be a better default.

On Fri, May 27, 2016 at 3:09 PM Eric Lindvall [email protected] wrote:

It seems that dirigiste is causing my java processes to not exit and I noticed that threads are not being started as daemon threads. Is that intentional? Is there something I should do to make my process exit nicely?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ztellman/dirigiste/issues/8, or mute the thread https://github.com/notifications/unsubscribe/AAB6P5N4LkFnJXJMK8U7FjrjWNlLzzmdks5qF2uXgaJpZM4Io5p7 .

ztellman avatar May 27 '16 22:05 ztellman

I've gone that route and it does appear to have fixed the hang I was seeing!

eric avatar May 27 '16 22:05 eric

It has been changed : https://github.com/clj-commons/dirigiste/commit/eac606222ee2976a4b8b94c060d424d5c0b1f37b

arnaudgeiser avatar Aug 22 '22 17:08 arnaudgeiser