Clint Valentine
Clint Valentine
Would you be willing to do a re-review?
@tfenne are you OK if we merge this?
I like this! I'm using [`GenomicSpan`](https://github.com/fulcrumgenomics/fgbio/blob/3f90c873aa91ee078be020e71ef5b89283b903a9/src/main/scala/com/fulcrumgenomics/util/GenomicSpan.scala) in a few places, so would it be possible to reconcile before merging?
I certainly could! I want to make a non-short-circuiting validation refactor but have not found the time: https://github.com/clintval/sample-sheet/issues/96 Right now, if anything looks "wrong" an exception is raised immediately. Instead...
It would also be awesome if it supported plugin validations so you could easily extend base validations with custom lab validations.
Hmm, I could use this in our lab too. I will do my best to carve out some time.
@colindaven I like where you are headed: > Output comments and errors go to an output txt file. Right now validation is fail-fast which really hurts the turn-around for making...
That's a good observation and should be supported! It may be a backwards incompatible feature request but I think an important one to better honor the specification: > Additional user-defined...
I believe the other mandatory section headers must be present even in the case of a truly empty sample sheet. I am currently re-working how validations are performed to make...
I would support this! Feel free to send over a PR, you'll probably beat me to it.