Dom Heinzeller comments

Results 314 comments of


                                            Dom Heinzeller

CMake can't find `MPI_Comm_f2c` resulting in unsafe cast in `nc_create_par_fortran`

So far, this looks to me like an issue with the cmake build of netcdf-c. I am seeing the same on my laptop with gcc-13. With the older spack v1...

CMake can't find `MPI_Comm_f2c` resulting in unsafe cast in `nc_create_par_fortran`

I think all that's needed is to add ``` if(MPI_mpi_LIBRARY) SET(CMAKE_REQUIRED_LIBRARIES ${MPI_mpi_LIBRARY} ${CMAKE_REQUIRED_LIBRARIES}) endif() ``` right before ``` CHECK_FUNCTION_EXISTS(MPI_Comm_f2c HAVE_MPI_COMM_F2C) CHECK_FUNCTION_EXISTS(MPI_Info_f2c HAVE_MPI_INFO_F2C) ``` In general, I wonder why this cmake...

CMake can't find `MPI_Comm_f2c` resulting in unsafe cast in `nc_create_par_fortran`

Unfortunately, my suggested bug fix didn't work reliably for all compilers. I have a better, yet still hacky solution, in https://github.com/spack/spack-packages/pull/2384. See comment https://github.com/spack/spack-packages/pull/2384#issuecomment-3524918903.

CODEOWNERS contains errors

None of them I guess.I think you should be an admin - I can add you if @mkavulich and @grantfirl concur.