simple-ldap-login
simple-ldap-login copied to clipboard
Debug log complains: "Undefined variable: version"
Wordpress 4.9.1 Simple LDAP Login 1.6.0
When reviewing my debug logs for an unrelated issue, I saw this message multiple times:
PHP Notice: Undefined variable: version in /var/www/html/puri.sm/wp-content/plugins/simple-ldap-login/Simple-LDAP-Login.php on line 54
This looks like it's been solved when checking the master branch. Maybe we could have a new release to fix it @clifgriffin ?
Also, ping @kwill for info.
Fyi @kwill, for now you could patch this in line 54:
54c54
< if( $this->get_setting('version') === false || $this->get_setting('version') != $version ) {
---
> if( $this->get_setting('version') === false || $this->get_setting('version') != $this->version ) {
bump
I added a pull request ( #56 ) that adds composer support, making this possible to fix for people running the plugin with composer through wpackagist at the moment. If you accept the merge we can just pull the plugin directly from github. @clifgriffin