Can't change tab [Windows]

[upgradeQ]

When I press Enter nothing happens.

[cliffordfajardo]

@HQupgradeHQ - hmmm. Are you using Windows/Mac?

I'm having trouble reproducing the error. So when you launch Cato, select the "Change Tab" command, no open tabs are showing up like in the GIF?

[upgradeQ]

@cliffordfajardo I am using Windows. I can see tabs, but I can't change them. On this GIF I'm pressing: hotkey to Cato, change command, arrows, Enter

GIF

[cliffordfajardo]

I'll try to setup a Windows environment and fix this. Thanks for reporting this!

Some follow up questions:

• What version of Google Chrome are you using?
• Can you try the 'Find Bookmark' and tell me if something similar is happening? I ask because change tab's code logic is similar to "find bookmark" and a few other actions

[upgradeQ]

version : Version 61.0.3163.100 (Official Build) (64-bit) 'Find Bookmark' works .

[Olian04]

@cliffordfajardo I have a windows environment i could try this on. I'l get to it later today.

[cliffordfajardo]

@Olian04 - in this branch I tried to use chrome.tabs instead of browser to see if the web-extension polyfil was the problem, but it doesn't look like it is. Even when using chrome. instead of browser. I'm having the same issues.

I also tried writing this in callback style and that didn't fix the issue.

A temporary fix I think (needs testing) is to just grab all the tabs for the current window ONLY, as opposed to all browser windows for the Windows operating system. The original code should stay the same for Linux/Mac.

Determining OS:

• https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/PlatformInfo

I think we'll need to do something like

//use destructuring to extract the os object.
const {os} = await browser.runtime.getPlatformInfo()
 if(os === 'win') {
   //grab all the tabs for the current window
} else {
 //use the original code
}

I'll look at this probably on Friday.

@Olian04 - just wanted to thank you for taking your time to learn about Cato and it's inner workings! Your the first officla contributor with your PR.

Hope I'm not being to nit-picky on the details for you 💪

Cheers

[abass]

Just came here to report this. Excellent work @cliffordfajardo - looking forward to a fix (:

[upgradeQ]

@cliffordfajardo Have a look on this extension, it's open source and has the ability to change window on windows.

[sendsent]

Hi @cliffordfajardo, just came here to report this too for Mac. When I type in "change to youtube" and have a youtube link up in another tab, it does not go there. No tabs show like in the GIF. Find Bookmark also has the same issue. Nothing will show.

Thanks - a :)

[cliffordfajardo]

@sendsent - I’m curious, what version of Google?

Thanks for reporting!

[sendsent]

@cliffordfajardo - Version 63.0.3239.132 (Official Build) (64-bit)

[taylorjdawson]

Has a fix for this been implemented?

[ln3333]

Same thing for me, but what makes it more strange is that when I opened a console(inspect the extension element) and tried to see if there're some errors, it functions well!

OS: Mac Mojava 10.14 Chrome: Version 72.0.3626.96 (Official Build) (64-bit)