amplesdk icon indicating copy to clipboard operation
amplesdk copied to clipboard

XUL: empty style attribute appearing in shadow child elements.

Open h6w opened this issue 14 years ago • 2 comments

Empty style attributes are appearing in the shadow child elements. I think it has to do with this section of code:

        aHtml.push('<tr style="');
        if (oElement.nodeType == ample.classes.Node.ELEMENT_NODE) {
            if (oElement.attributes["hidden"] == "true")
                aHtml[aHtml.length] = 'display:none;';
            if (oElement.viewType == cXULElement.VIEW_TYPE_VIRTUAL)
                aHtml[aHtml.length] = 'position:absolute;height:0;top:0;left:0;z-index:1;';
        }
        aHtml[aHtml.length] = '">';

If the element isn't hidden, and it's not virtual, then the result is an empty style attribute.

h6w avatar Oct 16 '11 03:10 h6w

ilinsky, you can assign this one to me. I'm pretty sure I'll have it fixed quickly.

h6w avatar Oct 16 '11 03:10 h6w

Cannot assign, as you are not yet part of the team. Fix and make pull request.

ilinsky avatar Oct 16 '11 16:10 ilinsky