Ciaran Liedeman

Results 55 comments of Ciaran Liedeman

Not sure if I should log a seperate issue but I have a related problem. The http.route is populate when the request is successful. The http.route is missing on 500s

@HamidEbr #5134 should fix this. As a temporary workaround you can manually add the tag using the enrich method: ```csharp .AddAspNetCoreInstrumentation(opts => { opts.Enrich = (string _, HttpContext context, ref...

Sure. Here is an example of how we could do it with enrich. ```csharp .AddAspNetCoreInstrumentation(opts => { opts.Enrich = (string _, HttpContext context, ref TagList tags) => { tags.Add("cancelled", context.RequestAborted.IsCancellationRequested);...

thanks @cijothomas that makes sense. I looked around in the semantic conventions at this [PR](https://github.com/open-telemetry/semantic-conventions/pull/205) and this open [issue](https://github.com/open-telemetry/semantic-conventions/issues/560) https://opentelemetry.io/docs/specs/semconv/http/http-spans/#common-attributes According to the docs for error.type we could stipulate timeout...

I am also experience this issue. In my case this was on a working install that hasn't been touched in months ``` cypress/browsers:node12.8.1-chrome80-ff72 ``` Is there any other external change...