Crash icon indicating copy to clipboard operation
Crash copied to clipboard

Updated Pipeline to improve consistency

Open clicky opened this issue 3 years ago • 2 comments

Description

The pipeline does not currently draw any annotations to the right scale. This PR fixes that and adds a lot more support for annotation rendering inside the pipeline. It doesn't give perfect full support (Which is the goal). But it vastly improves it for now.

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

  • [x] Tried the following annotation items, and this best describes the current support image

For reference, here is the current level of support, without this PR image

Checklist:

  • [x] My code follows the style of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the docs
  • [x] My changes generate no new warnings

clicky avatar Nov 11 '22 18:11 clicky

This looks great! I'm not sure why you have the leader say unsupported it works just fine for me crash-leader

One thing I noticed is that the DimAligned and DimAngle preview show the value twice: crash-annotations

karimi avatar Nov 16 '22 01:11 karimi

Thanks for taking a look @karimi,

Regarding leaders, this is why -> https://github.com/clicketyclackety/Crash/blob/8502b36ba0caaa78adf253cbf7dcc7f85034cb11/Crash/UI/DrawMethods.cs#L275-L279

I've found that when I use the pipeline. Annotations do not scale correctly and seem very small. So I just drew in the text on top. I'm unsure why yours scales correctly but mine doesn't? Maybe it has something to do with the current DimensionStyle?

clicky avatar Nov 19 '22 22:11 clicky