click-option-group icon indicating copy to clipboard operation
click-option-group copied to clipboard

Need type hints for decorator return types

Open vectro opened this issue 2 years ago • 2 comments

Because optgroup.group and optgroup.option do not have hints on their return types. mypy generates errors at the call site like Untyped decorator makes function "cli" untyped.

I think this could be resolved by adding type hints on the return values of these functions, as described in the mypy documentation.

vectro avatar Jan 25 '23 20:01 vectro

The documentation of how to type-check decorators is rather vague, especially in order to add optional arguments. If there is any example that would help.

LecrisUT avatar Aug 15 '23 23:08 LecrisUT

with the addition of the Decorator definition added in https://github.com/click-contrib/click-option-group/commit/a4684709885979585acc6767d786c217e49661da this should be fixable by adding the return type annotation -> Decorator to _OptGroup.group

tecknicaltom avatar Jun 07 '24 16:06 tecknicaltom