coro icon indicating copy to clipboard operation
coro copied to clipboard

Fix missing paren and add `#' to error macro

Open jwerle opened this issue 11 years ago • 4 comments

jwerle avatar Aug 07 '14 17:08 jwerle

cc @willemt @stephenmathieson

jwerle avatar Aug 07 '14 17:08 jwerle

@jwerle

How hard would it be to contribute changes back upstream? If it's possible, I think it'd be better than making the changes here, unless we've decided to actually maintain a version of libcoro here.

What do y'all think?

- Jonathan

@willemt @stephenmathieson

jonathanmarvens avatar Aug 07 '14 17:08 jonathanmarvens

Not hard at all if that is what we want to do :]

On Thu, Aug 7, 2014 at 1:23 PM, Jonathan Barronville < [email protected]> wrote:

@jwerle https://github.com/jwerle

How hard would it be to contribute changes back upstream http://software.schmorp.de/pkg/libcoro.html? If it's possible, I think it'd be better than making the changes here, unless we've decided to actually maintain a version of libcoro here.

What do y'all think?

  • Jonathan

@willemt https://github.com/willemt @stephenmathieson https://github.com/stephenmathieson

— Reply to this email directly or view it on GitHub https://github.com/clibs/coro/pull/1#issuecomment-51503377.

jwerle avatar Aug 07 '14 17:08 jwerle

lgtm and yeah if think any bug fixes here should definitely end up upstream

edit: it's cvs? fuck yeah.

stephenmathieson avatar Aug 07 '14 17:08 stephenmathieson