go-gh icon indicating copy to clipboard operation
go-gh copied to clipboard

TokenForHost "authentication token not found" message could be more informative

Open mislav opened this issue 2 years ago • 3 comments

Right now when gh auth token command fails for some reason, TokenForHost masks that with a generic "authentication token not found" error. I propose that the error also includes concrete reasons for the failure if they were known: for example, if gh wasn't found in the PATH.

mislav avatar Mar 14 '23 18:03 mislav

Not sure if this is relevant but I used to be able to get a graphql client without any issues previously but for some reason I now receive an error using the same method that was working before client, err := gh.GQLClient(nil) which returns an err along the lines of authentication token not found for host github.com. Is this to be expected or is there something that I'm missing?

tjgurwara99 avatar Apr 09 '23 14:04 tjgurwara99

We'd need more info to know what's going on there.

  1. Is your extension upgraded to the latest version of go-gh?
  2. Is gh in your PATH and up to date?
  3. Does gh auth status -h github.com work?
  4. Which OS are you on?

Thanks!

mislav avatar Apr 12 '23 11:04 mislav

Ok, so I was on go-gh v1.0.0 and updating to go-gh v1.2.1 fixed the issue on the extension for me - I should have done that before commenting 😅

tjgurwara99 avatar Apr 12 '23 15:04 tjgurwara99