cli Add `issue create --editor`

Part of https://github.com/cli/cli/issues/390

Mar 19 '23 06:03 notomo

Hey @notomo, sorry this PR has sat without review for so long. Since it was opened both @mislav and @vilmibm left the company. I assigned it to myself to review to try and get things moving again. Is this something you are still interested in getting merged in? If so, do you feel like there's anything more you would like to do before I review it?

Oct 04 '23 11:10 williammartin

@williammartin

Thanks for mentioning!

Is this something you are still interested in getting merged in?

Yes.

If so, do you feel like there's anything more you would like to do before I review it?

Now I resolved conflict. This is ready to review.

Oct 04 '23 12:10 notomo

Alright, thanks for resolving that. Just to give you a heads up, since this work was initially planned in #390, there has been additional discussion around delaying PR/Issue command improvements in light of https://github.com/cli/cli/issues/7575. It may be that we hold off on merging this until we get more clarity around how we want to approach this other work.

In the meantime, I wanted to make sure you were still interested, and to communicate exactly what the state of this PR is. You have put some work into it and it doesn't look like we've been valuing your time with clear communication. We will try to prioritise this PR and communication going forward.

Oct 04 '23 12:10 williammartin

I have also added this PR to the list of improvements on the tracking issue.

Oct 04 '23 12:10 williammartin

@notomo : firstly, let me apologize on behalf of the entire GitHub CLI team regarding how long this PR has languished due to our circumstances! 🙇 thank you, sincerely! 🫶

Seeing how this has languished, I've committed to reviewing this and working with you to shape these changes up if it is something you're still motivated working on. With that said, I think there are several product / user experience questions to ask outside of this PR in order to shape it. As such, I'm following up in https://github.com/cli/cli/issues/390#issuecomment-2168639181 for to gauge community feedback and interest.

Jun 14 '24 19:06 andyfeller

Thanks!

I agree to discuss before proceeding this PR. Depending on the conclusion of it, I think we should close this PR and rework. Then I'll make new one if it's not too hard for me.

Jun 15 '24 13:06 notomo

@andyfeller I committed the following features. Could you please review this PR?

issue create --editor and editor hint message
prefer_editor_prompt config

Jul 10 '24 11:07 notomo

@andyfeller I committed the following features. Could you please review this PR?

issue create --editor and editor hint message

prefer_editor_prompt config

Thank you for the hard work and patience, @notomo! 🤗 I'm going to focus on getting this reviewed today. Let's get the tests running and fix up any issues with status checks as those will obviously block the PR.

Jul 12 '24 15:07 andyfeller

Part of #390

@notomo : As we're not fully implementing the original issue, one thing we discussed internally to create a separate issue for the functionality we don't implement in the PR for the other commands. That way, we are able to close the issue without letting it blow up in scope.

I'll see about handling that and then will update the issue body above to reflect the state. 👍

Jul 12 '24 17:07 andyfeller

@andyfeller

Thanks for your reviewing! I answered questions and added a commit.

Jul 13 '24 02:07 notomo

Thank You Guys!

Jul 21 '24 03:07 Mapuppy09